> On Nov. 12, 2014, 9:34 p.m., Qian Xu wrote: > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java, > > line 84 > > <https://reviews.apache.org/r/27972/diff/1/?file=761053#file761053line84> > > > > The code block looks same as it in FromInitializer. Can it put to > > `SqlTypesUtils` or somewhere?
I wanted to file another ticket, since I know any unrelated refactoring in the same is frowned upon:) > On Nov. 12, 2014, 9:34 p.m., Qian Xu wrote: > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java, > > line 95 > > <https://reviews.apache.org/r/27972/diff/1/?file=761052#file761052line95> > > > > if columnName is an empty string... yesh I shud do a same util check as above > On Nov. 12, 2014, 9:34 p.m., Qian Xu wrote: > > common/src/main/java/org/apache/sqoop/schema/type/AbstractPrimitiveType.java, > > line 29 > > <https://reviews.apache.org/r/27972/diff/1/?file=761034#file761034line29> > > > > should the super class Column has a check against empty name? good point will just throw an exception - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27972/#review61207 ----------------------------------------------------------- On Nov. 12, 2014, 8:40 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27972/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2014, 8:40 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1715 > https://issues.apache.org/jira/browse/SQOOP-1715 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jIRA. > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java > 6dc93d5 > > common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexListType.java > 326fe1d > common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java > 880cb27 > common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java > 76b0542 > common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java > 1418aed > > common/src/main/java/org/apache/sqoop/schema/type/AbstractPrimitiveType.java > b8c39e5 > common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java > 9600c15 > common/src/main/java/org/apache/sqoop/schema/type/Array.java 7f8fda4 > common/src/main/java/org/apache/sqoop/schema/type/Binary.java 5c805ae > common/src/main/java/org/apache/sqoop/schema/type/Bit.java dfd7a2f > common/src/main/java/org/apache/sqoop/schema/type/Column.java 466eeea > common/src/main/java/org/apache/sqoop/schema/type/Date.java e0e85e5 > common/src/main/java/org/apache/sqoop/schema/type/DateTime.java 246e424 > common/src/main/java/org/apache/sqoop/schema/type/Decimal.java 66c368e > common/src/main/java/org/apache/sqoop/schema/type/Enum.java f2a60d9 > common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java a8442bb > common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java > 23679dc > common/src/main/java/org/apache/sqoop/schema/type/Map.java c85e70b > common/src/main/java/org/apache/sqoop/schema/type/Set.java aa796a3 > common/src/main/java/org/apache/sqoop/schema/type/Text.java d6582c0 > common/src/main/java/org/apache/sqoop/schema/type/Time.java d5774a1 > common/src/main/java/org/apache/sqoop/schema/type/Unknown.java df4061b > > common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java > aca67d1 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java > ef4ecc4 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java > 953497f > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/util/SqlTypesUtils.java > 572f0ec > > Diff: https://reviews.apache.org/r/27972/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
