> On Nov. 14, 2014, 4:52 a.m., Qian Xu wrote: > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java, > > line 69 > > <https://reviews.apache.org/r/28028/diff/1/?file=763296#file763296line69> > > > > General question: when the upgrader will be called? Currenlty config > > profile does not have a revision number. What will happen, if user upgrade > > from Sqoop 1.99.1 to 1.99.4 directly. > > Abraham Elmahrek wrote: > The upgrader is called at connector registration. > > I agree that the lack of knowledge of version is a bit difficult. > > Looking at 1.99.1 versus 1.99.2 versus 1.99.3 versus 1.99.4... all > versions simply add to their respective connectors, except for 1.99.4. This > means that only new features were added, never removed or changed, until > 1.99.4. In all cases, the existing names will be changed and the new > inputs/configs will be added to the database. > > Jarek Cecho wrote: > Not having version information can be indeed troublesome as the connector > developper is forced to do some self-detection. What about creating a follow > up JIRA to improve this in the future?
https://issues.apache.org/jira/browse/SQOOP-1732 - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28028/#review61403 ----------------------------------------------------------- On Nov. 14, 2014, 4:44 a.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28028/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 4:44 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1731 > https://issues.apache.org/jira/browse/SQOOP-1731 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit 813d8f8323bc29f8991b9deaa2ec4b951897e03e > Author: Abraham Elmahrek <[email protected]> > Date: Thu Nov 13 20:40:39 2014 -0800 > > SQOOP-1731: Sqoop2: Generic JDBC upgrade from 1.99.3 to 1.99.4 > > :100644 100644 fb92a39... 6e85c03... M > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java > :000000 100644 0000000... 6ee8b6c... A > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java > > > Diffs > ----- > > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java > fb92a39 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/28028/diff/ > > > Testing > ------- > > Added a unit test > > > Thanks, > > Abraham Elmahrek > >
