----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28200/#review62113 -----------------------------------------------------------
Ship it! This makes sense. - Abraham Elmahrek On Nov. 19, 2014, 1:19 a.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28200/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 1:19 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1754 > https://issues.apache.org/jira/browse/SQOOP-1754 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > We're currently using JarUtil class to help us find location of various jars. > The implementation is very buggy as it depends on jar name and default Class > Loader. We already do have facility in ClassUtils that is able to get > location of jar given class name and we should take advantage of that instead. > > > Diffs > ----- > > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java > f78786d > > Diff: https://reviews.apache.org/r/28200/diff/ > > > Testing > ------- > > Tested csv/avro/parquet jobs. > > > Thanks, > > Qian Xu > >
