> On Nov. 19, 2014, 4:58 a.m., Abraham Elmahrek wrote: > > common/src/main/java/org/apache/sqoop/schema/type/Enum.java, line 55 > > <https://reviews.apache.org/r/28110/diff/3/?file=767562#file767562line55> > > > > Interesting. Google had this library with preconditions as well. Good > > thinking.
I love preconditions. Kite uses preconditions for design contracts. It is a nice to have thing to check pre-/post/invariant conditions at early stage of design. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28110/#review62002 ----------------------------------------------------------- On Nov. 19, 2014, 6:49 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28110/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 6:49 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1716 > https://issues.apache.org/jira/browse/SQOOP-1716 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java > dec8c0e > common/src/main/java/org/apache/sqoop/schema/type/Enum.java 1388d49 > > common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java > 9f8ee3e > common/src/test/java/org/apache/sqoop/schema/type/TestEnum.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/28110/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
