> On Nov. 22, 2014, 1:22 a.m., Jarek Cecho wrote: > > server/src/main/java/org/apache/sqoop/server/RequestContext.java, line 129 > > <https://reviews.apache.org/r/28359/diff/1/?file=772925#file772925line129> > > > > Considering that this code is executed on server side and not user > > side, it means that we return here the server user as a default case when > > no user name is given by the request. That seems quite weird to me. > > > > The original method allowed returning null (if the header was > > unspecified), so I'm wondering if we should preserve the same "default" > > behaviour? Or perhaps define a special "default user" (that will be > > different then the user running sqoop2 server).
Good point Jarcec. Either way works for me. Let's just go with null until we better understand how user names will be managed? - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28359/#review62708 ----------------------------------------------------------- On Nov. 22, 2014, 1:20 a.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28359/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2014, 1:20 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1775 > https://issues.apache.org/jira/browse/SQOOP-1775 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit 40ae562f30fc3ef8969e5d45a243ed0baadf83d8 > Author: Abraham Elmahrek <[email protected]> > Date: Fri Nov 21 17:13:55 2014 -0800 > > SQOOP-1775: Use username during simple auth > > :100644 100644 db16107... 3c4a4d2... M > client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java > :100644 100644 d08c855... 8f4f709... M > common/src/main/java/org/apache/sqoop/common/SqoopProtocolConstants.java > :100644 100644 54e9cca... 9ecb2bc... M > server/src/main/java/org/apache/sqoop/server/RequestContext.java > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java > db16107 > common/src/main/java/org/apache/sqoop/common/SqoopProtocolConstants.java > d08c855 > server/src/main/java/org/apache/sqoop/server/RequestContext.java 54e9cca > > Diff: https://reviews.apache.org/r/28359/diff/ > > > Testing > ------- > > Manual > > > Thanks, > > Abraham Elmahrek > >
