> On Nov. 24, 2014, 1:31 a.m., Qian Xu wrote: > > core/src/main/java/org/apache/sqoop/security/AuthenticationManager.java, > > line 96 > > <https://reviews.apache.org/r/28375/diff/1/?file=773848#file773848line96> > > > > Do you mean trim the handler string (return value)?
Good point! - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28375/#review62747 ----------------------------------------------------------- On Nov. 23, 2014, 9:58 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28375/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2014, 9:58 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1792 > https://issues.apache.org/jira/browse/SQOOP-1792 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit 68fe75bdec24b7461c194d77c9d9f9350f3f1095 > Author: Abraham Elmahrek <[email protected]> > Date: Sun Nov 23 13:46:29 2014 -0800 > > SQOOP-1792: Sqoop2: Default to simple authentication type > > :100644 100644 1f7248b... 1b77fe2... M > core/src/main/java/org/apache/sqoop/security/AuthenticationManager.java > :100755 100755 3d18e7b... 26bf734... M > dist/src/main/server/conf/sqoop.properties > :100644 100644 4165b86... 41c4fb0... M > server/src/main/java/org/apache/sqoop/filter/SqoopAuthenticationFilter.java > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/security/AuthenticationManager.java > 1f7248b > dist/src/main/server/conf/sqoop.properties 3d18e7b > server/src/main/java/org/apache/sqoop/filter/SqoopAuthenticationFilter.java > 4165b86 > > Diff: https://reviews.apache.org/r/28375/diff/ > > > Testing > ------- > > manual. > > > Thanks, > > Abraham Elmahrek > >
