[
https://issues.apache.org/jira/browse/SQOOP-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224959#comment-14224959
]
Veena Basavaraj commented on SQOOP-1811:
----------------------------------------
I still do not understand one thing.
The setText and getText methods are supposed to be no-operations since we do
not want to have any conversions going on in between. So why will it have a
custom implementation ?
You can differ to not rename but I believe in this statement from the kafka
style guide..and expressed it.
{quote}
Clear code is preferable to comments. When possible make your naming so good
you don't need comments. When that isn't possible comments should be thought of
as mandatory, write them to be read.
{quote}
I also understand that there is no standard for CSV and hence proposed to
create a SqoopCSVUtils that makes it obvious for connectors to use and add this
in java doc.
Well I try to phrase my question and thoughts to the best, sometimes I
improvise, sure adding a new comment is something I would do.
> IDF API changes
> ---------------
>
> Key: SQOOP-1811
> URL: https://issues.apache.org/jira/browse/SQOOP-1811
> Project: Sqoop
> Issue Type: Sub-task
> Components: sqoop2-framework
> Reporter: Veena Basavaraj
> Fix For: 1.99.5
>
>
> 1. update the java docs for IDF apis.
> 2. Make the getTextData final and call it getCSV and setCSV, so it is
> obvious that we want to enforce CSV format
> the following code can move to the base class IntermediateDataFormat and
> made final, so there is no way to override this and we can enforce all to
> return String instead of generic T
> {code}
> // hold the string in IDF base class
> private final String text.
>
> public final String getCSVTextData() {
> return text;
> }
>
> public final void setCSVTextData(String text) {
> this.text = text;
> }
> {code}
> There is code in CSVIDF implementation that has the rules for CSV parsing
> that can be pulled out into CSV Utils so that the connectors can use
> The T in CSV happens to String, which is just a coincidence, If I write a new
> IDF implementation T can be a custom object that could encapsulate the whole
> row.
> Third, getData and setData can have custom implementation so they can be
> overriden to return the generic type T
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
