[
https://issues.apache.org/jira/browse/SQOOP-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226093#comment-14226093
]
Hudson commented on SQOOP-1786:
-------------------------------
FAILURE: Integrated in Sqoop2-hadoop100 #700 (See
[https://builds.apache.org/job/Sqoop2-hadoop100/700/])
SQOOP-1786: Sqoop2: Stop using JSONValue.parse method call (abraham:
https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=39e99cc5f049aca32dbc9ce25f28b85500b843f1)
* common/src/main/java/org/apache/sqoop/model/ConfigUtils.java
* common/src/test/java/org/apache/sqoop/json/TestLinksBean.java
* common/src/test/java/org/apache/sqoop/json/TestJobsBean.java
* common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
* common/src/test/java/org/apache/sqoop/json/TestDriverBean.java
*
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java
* common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java
* common/src/test/java/org/apache/sqoop/json/TestLinkBean.java
* tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java
* common/src/test/java/org/apache/sqoop/json/TestJobBean.java
* common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java
* common/src/test/java/org/apache/sqoop/json/TestThrowableBean.java
* server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java
* common/src/main/java/org/apache/sqoop/json/JSONUtils.java
* client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java
*
client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java
*
client/src/main/java/org/apache/sqoop/client/request/DriverResourceRequest.java
* common/src/test/java/org/apache/sqoop/json/TestSchemaBean.java
* common/src/main/java/org/apache/sqoop/json/util/SerializationError.java
* client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java
* common/src/test/java/org/apache/sqoop/json/TestConnectorsBean.java
* server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
* common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java
* client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java
* common/src/test/java/org/apache/sqoop/json/TestJSONUtils.java
*
client/src/main/java/org/apache/sqoop/client/request/VersionResourceRequest.java
* common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java
*
client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java
> Sqoop2: Stop using JSONValue.parse method call
> ----------------------------------------------
>
> Key: SQOOP-1786
> URL: https://issues.apache.org/jira/browse/SQOOP-1786
> Project: Sqoop
> Issue Type: Bug
> Affects Versions: 1.99.4
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 1.99.5
>
> Attachments: SQOOP-1786.patch
>
>
> While investigating SQOOP-1784, I've noticed that {{JSONValue.parse()}}
> method that we're using everywhere in the code base is [swallowing
> exceptions|http://json-simple.googlecode.com/svn/trunk/src/main/java/org/json/simple/JSONValue.java]
> and returning {{null}} on all failure scenarios.
> As this is causing a random {{NullPointerException}} being thrown elsewhere
> without proper information what went wrong, I would like to migrate to method
> {{JSONValue.parseWithException()}} instead. Given how much we're parsing
> JSONs inside Sqoop 2, I would also recommend to create a small Util class
> that will handle error cases and coverts the {{ParserException}} to
> {{SqoopException}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
