----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28477/#review63134 -----------------------------------------------------------
Ship it! Ship It! - Abraham Elmahrek On Nov. 26, 2014, 7:43 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28477/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2014, 7:43 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1816 > https://issues.apache.org/jira/browse/SQOOP-1816 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > I've added LoggerWriter a PrintWriter implementation that will forward all > messages to Logger and I've configured the Derby to use this. In addition > I've added the server.ping() call to ensure that Derby server started > properly. > > > Diffs > ----- > > > common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java > f7b91bb > > common-test/src/main/java/org/apache/sqoop/common/test/utils/LoggerWriter.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/28477/diff/ > > > Testing > ------- > > Integration tests are passing and I can see the log message(s) as expected. > > > Thanks, > > Jarek Cecho > >
