> On Nov. 26, 2014, 1:51 a.m., Abraham Elmahrek wrote:
> > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java,
> > line 397
> > <https://reviews.apache.org/r/28139/diff/7/?file=776412#file776412line397>
> >
> > What if one of the elements is a string with the quote character '?
there is test case for this public void testArrayOfComplexStrings() {
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28139/#review63103
-----------------------------------------------------------
On Nov. 25, 2014, 9:23 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28139/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 9:23 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1749
> https://issues.apache.org/jira/browse/SQOOP-1749
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see JIRA
>
> Arrays/ Nested/ Set
>
> The latest rev does not have time related changed, it is separate ticket
> See SQOOP-1771 for the detail of the JSON format.
>
>
> NOTE: WS will be addressed once the patch is reviewed for functionality and
> this needs a rebase since I have other patches pending review that overlap.
>
>
> Diffs
> -----
>
>
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java
> 39a01c1
>
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java
> 5ef6fc6
>
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormatError.java
> 4d41679
>
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java
> fcf6c3c
>
> Diff: https://reviews.apache.org/r/28139/diff/
>
>
> Testing
> -------
>
> yes unit tests added.
>
>
> Thanks,
>
> Veena Basavaraj
>
>
