> On Nov. 30, 2014, 6:28 a.m., Jarek Cecho wrote: > > Other then the unnecessary re-order of import statement, the patch looks > > good to me. > > Jarek Cecho wrote: > Please attach final patch to the JIRA and I'll commit it.
i have already uploaded the patch, and to make it more obvious it is not an unnecessary order, I just defined the order that we should be using in all files going forward, and that is com org java javax - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28537/#review63313 ----------------------------------------------------------- On Nov. 29, 2014, 3:09 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28537/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2014, 3:09 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1750 > https://issues.apache.org/jira/browse/SQOOP-1750 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > 4f2baf9 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > b629897 > > Diff: https://reviews.apache.org/r/28537/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > >
