----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28470/#review63329 -----------------------------------------------------------
Nice start, have a few comments. test/src/main/java/org/apache/sqoop/test/kdc/KdcRunner.java <https://reviews.apache.org/r/28470/#comment105557> if everything in this is static, can you u call this MiniKdUtil? it is standard convention used for helper/ util classes test/src/main/java/org/apache/sqoop/test/kdc/KdcRunner.java <https://reviews.apache.org/r/28470/#comment105558> you can easily create a nice small MiniKdcParameters class that takes temporary path and config and keytab and send this is in the start method, avoid all the getter /setters. test/src/main/java/org/apache/sqoop/test/utils/ConfigurationUtils.java <https://reviews.apache.org/r/28470/#comment105559> call it AuthConfigurationUtils, if this is only holding Auth info test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java <https://reviews.apache.org/r/28470/#comment105560> where are these imports used, dont see any code change that uses these i - Veena Basavaraj On Nov. 26, 2014, 12:53 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28470/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2014, 12:53 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Unit/ Integration test > It is a initial patch, just for review. The Simple auth works. The Kerberos > auth does not work. Next patch will fix this bug. > > Use Simple auth: mvn integration-test > -Dsqoop.hadoop.runner.class=org.apache.sqoop.test.hadoop.HadoopLocalRunner > Use Kerberos auth: mvn integration-test > -Dsqoop.hadoop.runner.class=org.apache.sqoop.test.hadoop.HadoopLocalRunner > -Dorg.apache.sqoop.authentication.type=kerberos > > > Diffs > ----- > > pom.xml ddcc5379ce879781a0618275dbe7e9a56d331536 > test/pom.xml cafa250d583eaede3058c375c3341479eee50ad8 > test/src/main/java/org/apache/sqoop/test/kdc/KdcRunner.java PRE-CREATION > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java > 4322b1cdb7841d2157d3fd1e4abf1b131dc94130 > test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java > 5e1d564aef2c8f566f7baa781009328bd0ca5e20 > test/src/main/java/org/apache/sqoop/test/utils/ConfigurationUtils.java > PRE-CREATION > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java > e482ac598d7dc9265922c9d2b6ad29abeb0c7b50 > > Diff: https://reviews.apache.org/r/28470/diff/ > > > Testing > ------- > > > Thanks, > > richard zhou > >
