----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28595/#review63820 -----------------------------------------------------------
Ship it! Seems good. The TestPartitioner tests are failing because the output they test against are missing quotes. - Abraham Elmahrek On Dec. 4, 2014, 4:25 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28595/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 4:25 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1815 > https://issues.apache.org/jira/browse/SQOOP-1815 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > bd0fbf0 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > 75fe429 > core/src/main/java/org/apache/sqoop/driver/JobManager.java d6efa6d > > Diff: https://reviews.apache.org/r/28595/diff/ > > > Testing > ------- > > yes > > integration PartiotionerTest still fails. > > > Thanks, > > Veena Basavaraj > >
