> On Dec. 3, 2014, 9:03 a.m., Jarek Cecho wrote: > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java, > > line 73 > > <https://reviews.apache.org/r/28636/diff/1/?file=781665#file781665line73> > > > > It seems that the schemaColumns variable will very likely be a > > LinkedList [1]. As schemaColumns.get() will be called for every row and > > every column, let's perhaps convert the List to Array, so that we get > > constant time lookup? > > > > 1: > > https://github.com/apache/sqoop/blob/sqoop2/common/src/main/java/org/apache/sqoop/schema/Schema.java#L62
there are couple of places this is done like convering to array, so might be a new ticket to change this to array, for now I have done toArray as it is done in CDV IDF - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28636/#review63680 ----------------------------------------------------------- On Dec. 3, 2014, 9:10 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28636/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 9:10 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1830 > https://issues.apache.org/jira/browse/SQOOP-1830 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/job/etl/ExtractorContext.java 4875ed0 > common/src/main/java/org/apache/sqoop/job/etl/LoaderContext.java 563b9ad > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorError.java > c291cb2 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java > af9320b > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java > d1e6805 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java > dee0242 > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java > 0a6369f > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java > d20c903 > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java > 664692a > > Diff: https://reviews.apache.org/r/28636/diff/ > > > Testing > ------- > > mvn test passes > > > Thanks, > > Veena Basavaraj > >
