----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28706/#review63885 -----------------------------------------------------------
Ship it! LGTM connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java <https://reviews.apache.org/r/28706/#comment106198> NIT: tf? - Abraham Elmahrek On Dec. 4, 2014, 6:16 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28706/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 6:16 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1765 > https://issues.apache.org/jira/browse/SQOOP-1765 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > this also has fixes to use 6 digit precision for milliseconds in date time as > per spec > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > a075d3f > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > bf15c69 > > Diff: https://reviews.apache.org/r/28706/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
