[
https://issues.apache.org/jira/browse/SQOOP-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235667#comment-14235667
]
Jarek Jarcec Cecho commented on SQOOP-1591:
-------------------------------------------
Copy & pasting my comments from [review
board|https://reviews.apache.org/r/26948/] that are relevant to this JIRA::
{quote}
I'm a bit worried about this approach as it will hide configuration issues -
e.g. if the database is down or credentials are missconfigured, the test will
still pass and the fact that we are not testing PostgreSQL repo will be
silently ignored.
Let's perhaps promote those tests into Integration tests similarly as we're
doing in test module [1] and add a flag to enable them?
Another idea would be to use JUnit categories [2] and it's maven integration to
run them in a special profile/flag.
I'm happy to take this one into subsequent JIRA as it's more general topic
though.
Links:
1: https://github.com/apache/sqoop/blob/sqoop2/test/pom.xml#L154
2:
https://weblogs.java.net/blog/johnsmart/archive/2010/04/25/grouping-tests-using-junit-categories-0
3: http://maven.apache.org/surefire/maven-surefire-plugin/examples/junit.html
{quote}
> Sqoop2: PostgreSQL integration tests
> ------------------------------------
>
> Key: SQOOP-1591
> URL: https://issues.apache.org/jira/browse/SQOOP-1591
> Project: Sqoop
> Issue Type: Sub-task
> Components: sqoop2-test
> Reporter: Abraham Elmahrek
>
> Use existing postgresql instance for integration testing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
