----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28776/#review64108 -----------------------------------------------------------
Ship it! LGTM connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java <https://reviews.apache.org/r/28776/#comment106548> Cool. Maybe TreeSet instead since the sets are small. connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java <https://reviews.apache.org/r/28776/#comment106550> Slightly easier to read for me: objectArray[i] = objectArray[i].toString(); if (!(TRUE_BIT_SET.contains(bitStringValue) || FALSE_BIT_SET.contains(bitStringValue))) { throw new SqoopException... } - Abraham Elmahrek On Dec. 5, 2014, 10:54 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28776/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 10:54 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1817 > https://issues.apache.org/jira/browse/SQOOP-1817 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > d481cce > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormatError.java > 665418d > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > b348ed8 > > Diff: https://reviews.apache.org/r/28776/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > >
