[
https://issues.apache.org/jira/browse/SQOOP-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237360#comment-14237360
]
Qian Xu edited comment on SQOOP-1845 at 12/8/14 3:33 AM:
---------------------------------------------------------
[~vybs] Please take it over, I'll be happy to review.
The motivation of my patch is to remove the hard coded timezone offset
"-07:00". If you change your timezone and rerun TestCSVIntermediateDataFormat,
some tests will fail!
{code}
Failed tests:
testDateTimeWithCSVTextInObjectArrayOut(org.apache.sqoop.connector.idf.TestCSVIntermediateDataFormat):
expected:<...4-10-01T12:00:00.000[-07]:00> but
was:<...4-10-01T12:00:00.000[+08]:00>
testDateTimePrecisionWithCSVTextInObjectArrayOut(org.apache.sqoop.connector.idf.TestCSVIntermediateDataFormat):
expected:<...4-10-01T12:00:00.000[-07]:00> but
was:<...4-10-01T12:00:00.000[+08]:00>
testDateTimeWithObjectInCSVTextOut(org.apache.sqoop.connector.idf.TestCSVIntermediateDataFormat):
expected:<...0-01 12:00:00.001000[-07]00'> but was:<...0-01
12:00:00.001000[+08]00'>
{code}
was (Author: stanleyxu2005):
[~abec] [~vybs] Please take it over, I'll be happy to review. The motivation of
my patch is to remove the hard coded timezone offset "-07:00".
> Make DateTime Column type support datetime with and without timezone (Unit
> test failed due to different timezone)
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SQOOP-1845
> URL: https://issues.apache.org/jira/browse/SQOOP-1845
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Richard
> Assignee: Veena Basavaraj
> Attachments: SQOOP-1845.patch, SQOOP-1845.patch
>
>
> test testDateTimeISO8601Alternative in TestCSVIntermediateDataFormat
> {code}
> assertEquals("2014-10-01T12:00:00.000-07:00",
> dataFormat.getObjectData()[0].toString());
> {code}
> failed with such error message:
> {code}
> org.junit.ComparisonFailure:
> Expected :2014-10-01T12:00:00.000-07:00
> Actual :2014-10-01T12:00:00.000+08:00
> {code}
> seems issue of a different timezone, you are @ -7, and I am @ +8.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
