[
https://issues.apache.org/jira/browse/SQOOP-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238273#comment-14238273
]
Sqoop QA bot commented on SQOOP-1858:
-------------------------------------
Testing file
[SQOOP-1858.patch|https://issues.apache.org/jira/secure/attachment/12685805/SQOOP-1858.patch]
against branch sqoop2 took 0:25:13.151076.
{color:red}Overall:{color} -1 due to 2 errors
{color:red}ERROR:{color} Some unit tests failed
{color:red}ERROR:{color} Failed unit test:
{{org.apache.sqoop.connector.idf.TestCSVIntermediateDataFormat}}
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All integration tests passed
Console output is available
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/716/console].
This message is automatically generated.
> Sqoop2: Print out warnings from git apply on output of precommit hook
> ---------------------------------------------------------------------
>
> Key: SQOOP-1858
> URL: https://issues.apache.org/jira/browse/SQOOP-1858
> Project: Sqoop
> Issue Type: Bug
> Affects Versions: 1.99.4
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 1.99.5
>
> Attachments: SQOOP-1858.patch
>
>
> Currently we only check the return value of executing {{git apply}} and
> printing it's stdin/stderr only if the return is not 0. However having
> warnings (for example trailing whitespace) won't change the return value and
> hence those get silently ignored. Hence I would suggest to enhance the
> precommit hook to print out the output {{git apply}} in case that it's not
> empty to highlight the warnings.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
