----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28795/#review64312 -----------------------------------------------------------
Have a couple high level thoughts. Good first shot. client/pom.xml <https://reviews.apache.org/r/28795/#comment106946> hadoop-common is very big I think. Is this the only place delegation token handling exists? pom.xml <https://reviews.apache.org/r/28795/#comment106945> Move to a separate Jira since we do not know what this will do? - Abraham Elmahrek On Dec. 8, 2014, 1:55 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28795/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2014, 1:55 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Delegation Token support for Authentication. > It depends on Hadoop 2.6.0+. Currently, Sqoop depends on Hadoop 2.5.1. Not > sure whether there is plan to upgrade Hadoop version from 2.5.1 to 2.6. > Anyway, sooner or Later, it will happen. > Initial patch with manual test. Integration test will be in another JIRA > SQOOP-1633 > > > Diffs > ----- > > client/pom.xml b53c9d3d74b7eeb8ff2a64bee1c8f7ec5144c281 > client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java > 6be1db87f94e1712399f724c740da1416389ba3b > common/src/main/java/org/apache/sqoop/common/MapContext.java > 2229889ca6fa45f70c938a04576b4c16999f4088 > dist/src/main/server/conf/sqoop.properties > fe4dfb62f74215b1521699cd7612c45d307365c2 > pom.xml e6ffc78cc332efa36b2a76c609bf37a57aeba1a7 > server/src/main/java/org/apache/sqoop/filter/SqoopAuthenticationFilter.java > bb6629047f1eaa89b42a3f99384e0f61a51a6b9a > > Diff: https://reviews.apache.org/r/28795/diff/ > > > Testing > ------- > > > Thanks, > > richard zhou > >
