[
https://issues.apache.org/jira/browse/SQOOP-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243797#comment-14243797
]
Veena Basavaraj edited comment on SQOOP-1878 at 12/12/14 7:02 AM:
------------------------------------------------------------------
[~jarcec] I am not sure what is blocked mean? This ticket was a suggestion to
fix the existing code to not run into surprises later. If both you and
[~gwenshap] are worried about the effort, it takes 15 mins to make this change
including a change to rest API docs to say we have made this a POST api, rather
than a GET, or added a new API to getSubmisisonStatusAndUpdateSubmission
Also,
Even the cache proposal does not address what my ticket was trying to fix
So a get no longer does update here, but who writes it into the DB? why do we
need this level of complexity when the the goal was to just fix the semantic
and stay true to what a GET really meant.
{code}
if(submission.lastlyUpdated().isAcceptablyOldInformation()) {
return submission;
} else {
return SubmissionEngine.getFreshUpdateAndReturnItToClient();
}
{code}
was (Author: vybs):
[~jarcec] I am not sure what is blocked mean? This ticket was a suggestion to
fix the existing code to not run into surprises later. If both you are Gwen are
worried about the effort, it takes 15 mins to make this change including a
change to rest API docs to say we have made this a POST api, rather than a GET,
or added a new API to getSubmisisonStatusAndUpdateSubmission
Also,
Even the cache proposal does not address what my ticket was trying to fix
So a get no longer does update here, but who writes it into the DB? why do we
need this level of complexity when the the goal was to just fix the semantic
and stay true to what a GET really meant.
{code}
if(submission.lastlyUpdated().isAcceptablyOldInformation()) {
return submission;
} else {
return SubmissionEngine.getFreshUpdateAndReturnItToClient();
}
{code}
> JobManager status method is a GET call and should not performa update
> operations
> --------------------------------------------------------------------------------
>
> Key: SQOOP-1878
> URL: https://issues.apache.org/jira/browse/SQOOP-1878
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Veena Basavaraj
> Assignee: Veena Basavaraj
> Fix For: 1.99.5
>
> Attachments: SQOOP-1878.patch
>
>
> JobManager status method is a GET call and should not performa update
> operations
> status () method on JobManager is get request from the rest API. it should
> not ever do an update.
> if we need more faster updates of job, then it is best to create a new action
> that can do it or reduce the updateSleep parameter to less than 5 minutes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
