----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29010/#review65012 -----------------------------------------------------------
Ship it! Remove white space and I think we're good. connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java <https://reviews.apache.org/r/29010/#comment107933> A static import of that single method might be better. I see 61 tests running. - Abraham Elmahrek On Dec. 12, 2014, 8:59 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29010/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2014, 8:59 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1813 > https://issues.apache.org/jira/browse/SQOOP-1813 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira and has +1 from Jarcec > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java > PRE-CREATION > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > e4a83b1 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java > e219948 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/common/TestSqoopIDFUtils.java > PRE-CREATION > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > 1a2a96f > > Diff: https://reviews.apache.org/r/29010/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > >
