[ 
https://issues.apache.org/jira/browse/SQOOP-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245419#comment-14245419
 ] 

Jarek Jarcec Cecho commented on SQOOP-1879:
-------------------------------------------

Good catch [~vybs]! I have few questions/notes:

1) It seems to me that the latest patch version still won't set all the 
{{MSubmission}} attributes. For example the error or counters field doesn't 
seem to be set. I'm wondering if I just missed it?
2) The newly introduced method {{prepareSubmission}} do have {{if(!isLocal()}} 
condition that will execute {{error}}, {{progress}}, {{counters}} and 
{{status}} methods. Each of those subsequent methods calls will then execute 
RPC to JobTracker/ResourceManager to get {{Job}} object that we already have. 
Hence I'm wondering if we can enhance the method to use the {{Job}} object 
directly? 

> Submission Engine does not set all details on SubmissionRecord in Local mode
> ----------------------------------------------------------------------------
>
>                 Key: SQOOP-1879
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1879
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Veena Basavaraj
>            Assignee: Veena Basavaraj
>         Attachments: SQOOP-1879-v1.patch
>
>
> {code}
>       // If we're in local mode than wait on completion. Local job runner do 
> not
>       // seems to be exposing API to get previously submitted job which makes
>       // other methods of the submission engine quite useless.
>       if(isLocal()) {
>         job.waitForCompletion(true);
>       } else {
>         job.submit();
>       }
> {code}
> the above code says that the job.waitForCompletion(true) is blocking and 
> hence the other submisison engine apis are useless in this local mode.
> But we dont set the all attributes of the job run into the submission record 
> in this case 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to