[
https://issues.apache.org/jira/browse/SQOOP-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245438#comment-14245438
]
Abraham Elmahrek commented on SQOOP-1783:
-----------------------------------------
[~jarcec], when I use `patch -p1 < file.patch`, I'm noticing:
{noformat}
patching file pom.xml
Hunk #2 succeeded at 391 (offset 13 lines).
patching file test/pom.xml
Hunk #1 succeeded at 117 (offset 5 lines).
patching file
test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java
patching file
test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java
patching file
test/src/main/java/org/apache/sqoop/test/utils/CompressionUtils.java
patching file
test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java
patching file
test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java
{noformat}
The 'Hunked' files seem to be producing `.orig` filenames:
{noformat}
abe@/users/abe/Projects/upstream/sqoop2> git status
On branch SQOOP-1756
Your branch is ahead of 'origin/sqoop2' by 1 commit.
(use "git push" to publish your local commits)
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)
modified: pom.xml
modified: test/pom.xml
modified:
test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java
modified:
test/src/main/java/org/apache/sqoop/test/testcases/TomcatTestCase.java
Untracked files:
(use "git add <file>..." to include in what will be committed)
SQOOP-1783.patch
pom.xml.orig
test/pom.xml.orig
test/src/main/java/org/apache/sqoop/test/utils/CompressionUtils.java
test/src/test/java/org/apache/sqoop/integration/repository/
{noformat}
I'm wondering if there's a chance the patch applies, but an error may have
occurred?
> Sqoop2: Create derby integration upgrade tests
> ----------------------------------------------
>
> Key: SQOOP-1783
> URL: https://issues.apache.org/jira/browse/SQOOP-1783
> Project: Sqoop
> Issue Type: Bug
> Affects Versions: 1.99.4
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 1.99.5
>
> Attachments: SQOOP-1783.patch, SQOOP-1783.patch,
> TEST-org.apache.sqoop.integration.repository.derby.upgrade.Derby1_99_4UpgradeTest.xml,
> derby-repository-1.99.4.tar.gz, sqoop.log, tomcat.log
>
>
> During my validation of 1.99.4 release, I've several times run upgrade
> scenario when I took repository generated by previous release and let the new
> release upgrade the structures. We've found several bugs during this manual
> exercise as we did several changes and we don't have any test coverage in
> this area. Hence for future releases I would like to introduce automatic
> upgrade tests that would run as a part of our integration test suite.
> I'm currently thinking of doing exactly what I've done in my manual exercise.
> We can create example derby repository that is exercising various different
> values for (all) previous releases and store that an archive with the code.
> The integration tests will then untar the stored archive and simply run the
> upgrade procedure This approach won't guarantee that we will catch all
> upgrade bugs, but will provide reasonable confidence that we can release the
> new bits without additional manual testing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
