> On Dec. 14, 2014, 9:06 a.m., Jarek Cecho wrote: > > execution/mapreduce/src/main/java/org/apache/sqoop/job/io/SqoopWritable.java, > > line 34 > > <https://reviews.apache.org/r/29025/diff/3/?file=791543#file791543line34> > > > > I'm wondering here. The SqoopWritable can (and probably will) be used > > in both "From" and "To" context rigth? So we should probably load the > > correct IDF and not assume that it's "to". > > Veena Basavaraj wrote: > when it is we can get there, at this point it is used as the writable for > the loader and I rather make it clear that it is then forward thinking for > reasons it might not even be relevant now
I even thought of renaming it to the ToWritable, but I know some people on this project consider renames as the only think I do, so I wanted to spare that discussion in the RB - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29025/#review65049 ----------------------------------------------------------- On Dec. 14, 2014, 8:49 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29025/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2014, 8:49 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1882 > https://issues.apache.org/jira/browse/SQOOP-1882 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see JIRA > > It fixes few things > > JobManager currently ignores the TO connector IDF. > Sqoop Mapper IDF cannot assume the type to be String > Using Set for jars than list, so we can avoid duplicates > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > dbe193d > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java > 93698a8 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > 83a95ec > core/src/main/java/org/apache/sqoop/driver/JobManager.java 01073d4 > core/src/main/java/org/apache/sqoop/driver/JobRequest.java 8c1cc95 > > execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java > 9b3eb44 > execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java > 67021a8 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/io/SqoopWritable.java > 336ab97 > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java > 7434243 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java > d664337 > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java > 256c34d > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java > 67c8525 > > execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java > d897125 > > Diff: https://reviews.apache.org/r/29025/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > >
