----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29016/#review65503 -----------------------------------------------------------
Ship it! Works now! - Abraham Elmahrek On Dec. 17, 2014, 7:06 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29016/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 7:06 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1890 > https://issues.apache.org/jira/browse/SQOOP-1890 > > > Repository: sqoop-trunk > > > Description > ------- > > I've several places where the proper escaping has been missing. > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/HsqldbManager.java 54a104d > src/java/org/apache/sqoop/tool/ImportTool.java bdb23bb > src/test/com/cloudera/sqoop/TestIncrementalImport.java b456ca6 > src/test/com/cloudera/sqoop/TestMerge.java cc1a3a9 > src/test/com/cloudera/sqoop/metastore/TestSavedJobs.java 9f36f63 > src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java a94ab90 > src/test/com/cloudera/sqoop/testutil/HsqldbTestServer.java 4b70e5a > > Diff: https://reviews.apache.org/r/29016/diff/ > > > Testing > ------- > > I've added a new test case that tests entire incremental import with > tablename tha have "problematical" characters. > > > Thanks, > > Jarek Cecho > >
