> On Dec. 14, 2014, 1:53 a.m., Veena Basavaraj wrote: > > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java, > > line 71 > > <https://reviews.apache.org/r/26581/diff/4/?file=791327#file791327line71> > > > > I had this same question in KiteConnector as well , do we need to > > createConnection every time? > > Veena Basavaraj wrote: > looks like you chose not to do this for ease, but I wonder does this have > any perf issue with so many calls to get connection
It probably will. I'd like to address this in a separate Jira because it's a big usage question. It'll probably require it's own context, similar to Repository.java#doWithConnection. > On Dec. 14, 2014, 1:53 a.m., Veena Basavaraj wrote: > > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java, > > line 48 > > <https://reviews.apache.org/r/26581/diff/4/?file=791328#file791328line48> > > > > is it ok for the loader to write JODA date time objects? > > > > Can we have more unit tests per data type on how it gets written ? > > > > Or is this something we will cover in integration tests? There is only one data type for HBase: Binary. Testing of types will be covered more extensively in integration tests. > On Dec. 14, 2014, 1:53 a.m., Veena Basavaraj wrote: > > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java, > > line 29 > > <https://reviews.apache.org/r/26581/diff/4/?file=791333#file791333line29> > > > > ditto: does not any of these have any validations? Ots ok if you want > > to address in a new ticket, please add that in Jira: https://issues.apache.org/jira/browse/SQOOP-1928 - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26581/#review65034 ----------------------------------------------------------- On Dec. 14, 2014, 12:26 a.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26581/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2014, 12:26 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1156 > https://issues.apache.org/jira/browse/SQOOP-1156 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit b9af5c1556e2c88a3c861950a6a296733fa1e4e7 > Author: Abraham Elmahrek <[email protected]> > Date: Thu Oct 9 22:56:34 2014 -0700 > > SQOOP-1156: HBase connector > > :000000 100644 0000000... 61dd408... A connector/connector-hbase/pom.xml > :000000 100644 0000000... b0e4ea0... A > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java > :000000 100644 0000000... 975cb40... A > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java > :000000 100644 0000000... 2e08bfd... A > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java > :000000 100644 0000000... cf632c9... A > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorRepositoryUpgrader.java > :000000 100644 0000000... bc61993... A > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java > :000000 100644 0000000... 991846f... A > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java > :000000 100644 0000000... 325591c... A > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java > :000000 100644 0000000... 51fd885... A > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java > :000000 100644 0000000... 6e306b1... A > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java > :000000 100644 0000000... a4b825c... A > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java > :000000 100644 0000000... 15feb54... A > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java > :000000 100644 0000000... cc71b78... A > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java > :000000 100644 0000000... 15a9425... A > connector/connector-hbase/src/main/resources/hbase-connector-resources.properties > :000000 100644 0000000... 1fc360e... A > connector/connector-hbase/src/main/resources/sqoopconnector.properties > :000000 100644 0000000... c78042a... A > connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestExecutor.java > :000000 100644 0000000... 60f8217... A > connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestLoader.java > :000000 100644 0000000... 44ffced... A > connector/connector-hbase/src/test/resources/log4j.properties > :100644 100644 e98a0fc... 35c665e... M connector/pom.xml > :100644 100644 f25a29f... a556bcf... M pom.xml > :100644 100644 67baaa5... 21a1fa9... M server/pom.xml > :100644 100644 7a80710... fbd4e84... M test/pom.xml > > > Diffs > ----- > > connector/connector-hbase/pom.xml PRE-CREATION > > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnector.java > PRE-CREATION > > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorConstants.java > PRE-CREATION > > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorError.java > PRE-CREATION > > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseConnectorUpgrader.java > PRE-CREATION > > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseExecutor.java > PRE-CREATION > > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseLoader.java > PRE-CREATION > > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToDestroyer.java > PRE-CREATION > > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/HBaseToInitializer.java > PRE-CREATION > > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfig.java > PRE-CREATION > > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/LinkConfiguration.java > PRE-CREATION > > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfig.java > PRE-CREATION > > connector/connector-hbase/src/main/java/org/apache/sqoop/connector/hbase/configuration/ToJobConfiguration.java > PRE-CREATION > > connector/connector-hbase/src/main/resources/generic-jdbc-connector-config.properties > PRE-CREATION > connector/connector-hbase/src/main/resources/sqoopconnector.properties > PRE-CREATION > > connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseExecutor.java > PRE-CREATION > > connector/connector-hbase/src/test/java/org/apache/sqoop/connector/hbase/TestHBaseLoader.java > PRE-CREATION > connector/connector-hbase/src/test/resources/log4j.properties PRE-CREATION > connector/pom.xml dfa7e88 > pom.xml efb9659 > server/pom.xml 77477ee > test/pom.xml 35d36c1 > > Diff: https://reviews.apache.org/r/26581/diff/ > > > Testing > ------- > > mvn clean verify + can transfer from mysql to hbase. > > > Thanks, > > Abraham Elmahrek > >
