----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29273/#review65696 -----------------------------------------------------------
Since these are mostly just test changes I think we can go with this. One comment - not new code, but might be worth fixing now that this is being moved around common/src/main/java/org/apache/sqoop/validation/validators/CSVURIValidator.java <https://reviews.apache.org/r/29273/#comment108905> You probably want to also validate that the port is a valid port number. - Hari Shreedharan On Dec. 19, 2014, 10:29 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29273/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2014, 10:29 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1927 > https://issues.apache.org/jira/browse/SQOOP-1927 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit cf38d79f989fdcb9539b5ac1eae781a70186d98b > Author: Abraham Elmahrek <[email protected]> > Date: Thu Dec 18 13:14:23 2014 -0800 > > SQOOP-1927: Sqoop2: Move CSVURIValidator into validators package > > :000000 100644 0000000... 32cb6e4... A > common/src/main/java/org/apache/sqoop/validation/validators/CSVURIValidator.java > :000000 100644 0000000... dc6f0d4... A > common/src/test/java/org/apache/sqoop/validation/validators/TestCSVURIValidator.java > :100644 100644 98112e7... 256ae64... M > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/LinkConfig.java > :100644 100644 b61d979... c4ffab8... M > connector/connector-kafka/src/test/java/org/apache/sqoop/connector/kafka/TestConfigValidator.java > > > Diffs > ----- > > > common/src/main/java/org/apache/sqoop/validation/validators/CSVURIValidator.java > PRE-CREATION > > common/src/test/java/org/apache/sqoop/validation/validators/TestCSVURIValidator.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/LinkConfig.java > 98112e7 > > connector/connector-kafka/src/test/java/org/apache/sqoop/connector/kafka/TestConfigValidator.java > b61d979 > > connector/connector-kafka/src/test/java/org/apache/sqoop/connector/kafka/TestConfiguration.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/29273/diff/ > > > Testing > ------- > > mvn test > > > Thanks, > > Abraham Elmahrek > >
