> On Dec. 24, 2014, 7:19 p.m., Veena Basavaraj wrote: > > +1 on upgrading, but if we are not using htrace yet in server why add it? > > are you preparing for some other ticket? if that is the case can we add it > > there.
also I read the ticket discussion more and it looks like we have this compile time 2.6 dependency for server, and run time it uses the classes in the catalina. are we documenting this somewhere in a doc or wiki that from 1.99.5 we have this, so that if we do see issues at runtime we know this will be the cause? - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29414/#review66068 ----------------------------------------------------------- On Dec. 24, 2014, 7:07 p.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29414/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2014, 7:07 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Include org.htrace.htrace-core which is new added in Hadoop 2.6.0 > > > Diffs > ----- > > pom.xml afdeb75da5e312e82bcd1c1520382fa53e743048 > server/pom.xml 77477eeeb51f3ace03fae8aebca4665ba00f36be > > test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java > 4aa8562baec2e7d999b45f394842d4024bde3f80 > > Diff: https://reviews.apache.org/r/29414/diff/ > > > Testing > ------- > > > Thanks, > > richard zhou > >
