[ 
https://issues.apache.org/jira/browse/SQOOP-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qian Xu updated SQOOP-1650:
---------------------------
    Assignee: Veena Basavaraj

> Code Bad Smell: Should create a JSONArray as return value rather than passing 
> as argument
> -----------------------------------------------------------------------------------------
>
>                 Key: SQOOP-1650
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1650
>             Project: Sqoop
>          Issue Type: Task
>            Reporter: Qian Xu
>            Assignee: Veena Basavaraj
>            Priority: Trivial
>
> This is a follow-up refactoring task for 
> https://reviews.apache.org/r/27330/#comment100567
> A JSONArray is passed into function as reference. You cannot guarantee code 
> not remove any existing element of the array. Expected is to return a new 
> JSONArray, so that the caller is responsible to use the array or merging 
> target array with this one.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to