----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29565/#review66607 -----------------------------------------------------------
The changes on high level looks good to me, but I would prefer if someone else who is more familiar with Kite would take a look as well :) connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnectorUpgrader.java <https://reviews.apache.org/r/29565/#comment110189> The Kite connector doesn't seem to be part of 1.99.3 nor 1.99.4 [1], so I'm assuming that proper upgrade path from those versions is not required? Links: 1: https://github.com/apache/sqoop/tree/branch-1.99.4/connector Jarcec - Jarek Cecho On Jan. 5, 2015, 8:02 a.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29565/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2015, 8:02 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1751 > https://issues.apache.org/jira/browse/SQOOP-1751 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > This is a follow up jira of SQOOP-1588. > > Two things should be changed: > 1. The File Output Format should be moved to ToJobConfig. > 2. Credential configs should be kept in LinkConfig (such as HDFS host and > port, which should be read from environment or here, not from toJobConfig.uri) > > Note that the current upgrade api does not allow `toJobConfig` or > `fromJobConfig` to access original `linkConfig` (also in reverse direction), > so it is not able to read valueFoo from linkConfig into toJobConfig. I > fallback to a default value manually. > > > Diffs > ----- > > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnectorUpgrader.java > d3b9f95 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteLoader.java > 0a46f4a > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToDestroyer.java > 25912b4 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java > 11233a8 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ConfigUtil.java > PRE-CREATION > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/LinkConfig.java > 89bd9b3 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ToJobConfig.java > 70b7dc3 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/util/InputValidation.java > 53fab02 > > connector/connector-kite/src/main/resources/kite-connector-config.properties > 27c77b4 > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteConnectorConfigurations.java > PRE-CREATION > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteConnectorUpgrader.java > PRE-CREATION > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteLoader.java > a1016a0 > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteToDestroyer.java > 4051fda > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteToInitializer.java > 5f0525d > > Diff: https://reviews.apache.org/r/29565/diff/ > > > Testing > ------- > > Added test cases to check config objects are expected after upgrade. > > > Thanks, > > Qian Xu > >
