----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29578/#review66612 -----------------------------------------------------------
Ship it! Thank you for the quick response Ricky! Please upload the latest patch to the JIRA and I'll commit it. - Jarek Cecho On Jan. 5, 2015, 9:20 a.m., Ricky Nguyen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29578/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2015, 9:20 a.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Bugs: SQOOP-1826 > https://issues.apache.org/jira/browse/SQOOP-1826 > > > Repository: sqoop-trunk > > > Description > ------- > > fix and test NPE bug encountered in SQOOP-1826 > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java 8d4a097 > src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java 3b5731b > > Diff: https://reviews.apache.org/r/29578/diff/ > > > Testing > ------- > > added test testDirectIncrementalImport. test currently passes (regardless of > this fix). > added test testDirectIncrementalImportMerge. test fails and reproduces NPE > in SQOOP-1826. test passes with the fix. > > with fix, all tests in PostgresqlImportTest pass. > > > Thanks, > > Ricky Nguyen > >
