[ 
https://issues.apache.org/jira/browse/SQOOP-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264491#comment-14264491
 ] 

ASF subversion and git services commented on SQOOP-1969:
--------------------------------------------------------

Commit 1cf075fdff3b685073f6d079f8dee44776701c2e in sqoop's branch 
refs/heads/sqoop2 from [~jarcec]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=1cf075f ]

SQOOP-1969: Support getColumnSize method for Schema class

(Qian Xu via Jarek Jarcec Cecho)


> Support getColumnSize method for Schema class
> ---------------------------------------------
>
>                 Key: SQOOP-1969
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1969
>             Project: Sqoop
>          Issue Type: Improvement
>          Components: connectors/generic
>    Affects Versions: 2.0.0
>            Reporter: Jerry Chen
>            Assignee: Qian Xu
>         Attachments: SQOOP-1969.patch
>
>
> Currently, Schema class don't have getColumnSize method. There are a lot of 
> places in Matcher implementations getMatchingData calling 
> getColumnsArray().length to purely get the column size. While getColumnsArray 
> a method not efficient as it looks like:
> {quote}
> public Column[] getColumnsArray() 
>     return columns.toArray(new Column[columns.size()]);
> {quote}
> It is suggested to add getColumnSize method in schema and the caller can use 
> this method to return the column length. 
> This problem gets serious because getMatchingData is called repeatedly with 
> each record in Mapper.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to