[
https://issues.apache.org/jira/browse/SQOOP-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265397#comment-14265397
]
Sqoop QA bot commented on SQOOP-1901:
-------------------------------------
Testing file
[SQOOP-1901-v6.patch|https://issues.apache.org/jira/secure/attachment/12690177/SQOOP-1901-v6.patch]
against branch sqoop2 took 0:30:11.435916.
{color:red}Overall:{color} -1 due to 2 errors
{color:red}ERROR:{color} File {{spi/target/.plxarc}} have missing licence header
{color:red}ERROR:{color} Failed to run license check (exit code 1,
[report|https://builds.apache.org/job/PreCommit-SQOOP-Build/870/artifact/patch-process/rat.txt])
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed
{color:green}SUCCESS:{color} All integration tests passed
Console output is available
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/870/console].
This message is automatically generated.
> Supporting DRY code in new IDF impementation JSONIDF
> ----------------------------------------------------
>
> Key: SQOOP-1901
> URL: https://issues.apache.org/jira/browse/SQOOP-1901
> Project: Sqoop
> Issue Type: Sub-task
> Components: sqoop2-framework
> Reporter: Veena Basavaraj
> Assignee: Veena Basavaraj
> Fix For: 1.99.5
>
> Attachments: SQOOP-1901-v2.patch, SQOOP-1901-v4.patch,
> SQOOP-1901-v5.patch, SQOOP-1901-v6.patch
>
>
> As the title suggests, we want to encourage DRY code in the new IDF
> implementations.
> As the IDF api mandates CSV and object format for all its sub implementation,
> I propose we move the common functionality to the base IDF class so that JSON
> IDF or AvroIDF does not have to repeat this code.
> The only parts of the code that needs to be in subclasses is how then handle
> the conversion between the "T" ( generic parameter) and the csv/ object
> representations.
> I saw that http://ingest.tips/2014/12/11/sqoop-1-99-4-release/ mentions
> extensind from CSVIDF and this cannot technically work since we have the
> generic T that will be different for AvroIDF or JSON IDF
> Update:
> Also extending from CSVIDF seems a bit ilogical, since the IDF API says that
> it needs CSV and object Array, these functionality of converting between the
> two i.e text to object and object to text should be in base class.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
