[
https://issues.apache.org/jira/browse/SQOOP-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265797#comment-14265797
]
Veena Basavaraj commented on SQOOP-1956:
----------------------------------------
Few more cleanups:
- We do not need the indices set in the base class, we can use the switch case
on the column type to determine the type for every row.
- made sure we throw an exception on null or unset schema since schema is
required.
- add some comment on why we have a no argument constructor for the IDFs and
that is required for the reflection magic
> clean up the SQOOPIDFUtils encodeAs*** methods to return a string
> -----------------------------------------------------------------
>
> Key: SQOOP-1956
> URL: https://issues.apache.org/jira/browse/SQOOP-1956
> Project: Sqoop
> Issue Type: Sub-task
> Components: sqoop2-framework
> Reporter: Veena Basavaraj
> Fix For: 1.99.5
>
>
> Comments from Qian on SQOOP-1901 RB
> https://reviews.apache.org/r/29346/#comment109331
> There are two versions of encodeToCSVLocalDateTime. One will update argument
> and another one will return a string. first one is very tricky to use. It's
> name does not imply the first argument will be changed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
