+1 for the window as almost all contributions for Sqoop 2 might get affected by this change (Sqoop 1 contributions won’t get affected though).
I’m more than happy to help finishing the review and commit the SQOOP-1950 patch in the window, but sadly neither of the proposed windows is suitable for me. I’m traveling on Thursday/Friday and on Thursday 12 PM PST I’ll be in a bus heading towards Prague and on Friday 12 PM PST in a plane :) I’m wondering if there is any other committer who can jump in, finish the review and commit the patch in one of the proposed windows? Jarcec > On Jan 6, 2015, at 10:10 AM, Abraham Elmahrek <[email protected]> wrote: > > Hey guys, > > Based on the feedback in SQOOP-1950, it seems we might need a window that > we can commit the TestNG changes in. Essentially, SQOOP-1950 changes every > test case in Sqoop to use TestNG rather than JUnit. Whenever a new test is > added, the test must be changed to use TestNG. Is it acceptable to define a > window where no commits occur in order to get this patch in? If so, how > does Thursday or Friday at 12PM PST work for folks? This window would only > have to be 2 hours to get the patch updated and in I think. > > -Abe
