----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29683/#review67141 -----------------------------------------------------------
Ship it! A few nits. LGTM. connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java <https://reviews.apache.org/r/29683/#comment110998> Is this used? connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormatError.java <https://reviews.apache.org/r/29683/#comment110989> 0004? connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormatError.java <https://reviews.apache.org/r/29683/#comment110991> 0004? - Abraham Elmahrek On Jan. 7, 2015, 11:29 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29683/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2015, 11:29 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1902 > https://issues.apache.org/jira/browse/SQOOP-1902 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira and the design wiki > https://cwiki.apache.org/confluence/display/SQOOP/Avro+Intermediate+Data+Format > > > Diffs > ----- > > connector/connector-sdk/pom.xml 46cb9f8 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopAvroUtils.java > PRE-CREATION > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java > 979aa4f > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java > PRE-CREATION > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormatError.java > PRE-CREATION > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > be1147d > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormatError.java > a88db45 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java > adeb2ec > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormatError.java > bda75fc > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java > 9329cf8 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestAVROIntermediateDataFormat.java > PRE-CREATION > pom.xml 4dbc48f > > Diff: https://reviews.apache.org/r/29683/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > >
