----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29654/#review67381 -----------------------------------------------------------
Ship it! Ship It! - Abraham Elmahrek On Jan. 7, 2015, 3:21 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29654/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2015, 3:21 a.m.) > > > Review request for Sqoop and Jerry Chen. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Investigation: > It will fail if doHttpRequest method has not run before running > addDelegationTokens method, since the strURL, which is set in doHttpRequest > method, will be used in addDelegationTokens method. > Solution: > Remove this strURL param in ResourceRequest, and add strURL as input in > addDelegationTokens method. So a valid strURL is needed when running > addDelegationTokens. > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/request/ResourceRequest.java > e55ba360bea845a0acc677fa204a27e708adc53c > > Diff: https://reviews.apache.org/r/29654/diff/ > > > Testing > ------- > > > Thanks, > > richard zhou > >
