----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29830/#review67793 -----------------------------------------------------------
Ship it! This seems good except for NITs. JSON should have some kind of other comparable interface as well, but maybe a follow up Jira. connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java <https://reviews.apache.org/r/29830/#comment111870> Unnecessary? connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java <https://reviews.apache.org/r/29830/#comment111871> Unnecessary? connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java <https://reviews.apache.org/r/29830/#comment111869> NIT: Put NOTE in comments above. - Abraham Elmahrek On Jan. 12, 2015, 11:59 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29830/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 11:59 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1936 > https://issues.apache.org/jira/browse/SQOOP-1936 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java > 67b47e7 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > 856a4bb > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java > 261a462 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java > b937d87 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/io/SqoopWritable.java > 08c2031 > > execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestSqoopWritable.java > 6a14201 > > Diff: https://reviews.apache.org/r/29830/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
