[ 
https://issues.apache.org/jira/browse/SQOOP-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276946#comment-14276946
 ] 

Qian Xu commented on SQOOP-2011:
--------------------------------

I've already created SQOOP-1976 and explained a bit about it. 

We'd better rename {{getColumnsList}} back to {{getColumns}} and remvoe 
{{getColumnsArray}}. I've already changed the internal implementation of the 
columns (type: List<Column>) from LinkedList to ArrayList already, so the 
lookup time is constant. I'll provide patch for SQOOP-1976 soon.

Do you mind to close the jira?

> Schema should expose columns in array or list and not both
> ----------------------------------------------------------
>
>                 Key: SQOOP-2011
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2011
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Veena Basavaraj
>             Fix For: 2.0.0
>
>
> it is asking for trouble to store the schema columns in array and expose a 
> list. the matching code currently uses LIST and it can completely use the 
> array and work with it. In all places in IDF code we use the column array via 
> the index.
> Array is preferred since it is easier to walk thorugh the object array 
> format, there is one-one correspondence between the two with indexes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to