----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29876/#review68157 -----------------------------------------------------------
one broader question, do we need to use hadoop annotation ? I was hoping we can define a sqoop annotation. Even Kafka if it does its own API stability handling would actually add its own mirroeing may be the guidelines from hadoop - Veena Basavaraj On Jan. 13, 2015, 7:26 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29876/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 7:26 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1926 > https://issues.apache.org/jira/browse/SQOOP-1926 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit ca28993b58a0a1cf52e4d4c612ce7af0e81e4de1 > Author: Abraham Elmahrek <[email protected]> > Date: Tue Jan 13 18:05:38 2015 -0800 > > SQOOP-1926: Sqoop2: Add annotations for visibilty and compatibility > guarantees > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/SqoopClient.java e1f009c > common/src/main/java/org/apache/sqoop/common/Direction.java 1576b96 > common/src/main/java/org/apache/sqoop/common/DirectionError.java 288c954 > common/src/main/java/org/apache/sqoop/common/ErrorCode.java 0458a57 > common/src/main/java/org/apache/sqoop/common/ImmutableContext.java 69f3a03 > common/src/main/java/org/apache/sqoop/common/MapContext.java d1f9420 > common/src/main/java/org/apache/sqoop/common/MutableContext.java ddf8af0 > common/src/main/java/org/apache/sqoop/common/MutableMapContext.java bb03ec0 > common/src/main/java/org/apache/sqoop/common/PrefixContext.java 6434e6d > common/src/main/java/org/apache/sqoop/common/SqoopException.java 6c5dc2a > common/src/main/java/org/apache/sqoop/common/SqoopProtocolConstants.java > 8f4f709 > common/src/main/java/org/apache/sqoop/common/SqoopResponseCode.java 93a43f5 > common/src/main/java/org/apache/sqoop/common/SupportedDirections.java > c527117 > common/src/main/java/org/apache/sqoop/common/VersionAnnotation.java 728a3a7 > common/src/main/java/org/apache/sqoop/common/VersionInfo.java 1b4873b > common/src/main/java/org/apache/sqoop/etl/io/DataReader.java a555431 > common/src/main/java/org/apache/sqoop/etl/io/DataWriter.java 2166b09 > common/src/main/java/org/apache/sqoop/job/etl/DestroyerContext.java 7afb120 > common/src/main/java/org/apache/sqoop/job/etl/ExtractorContext.java 1e0f0ec > common/src/main/java/org/apache/sqoop/job/etl/InitializerContext.java > 4de00a6 > common/src/main/java/org/apache/sqoop/job/etl/LoaderContext.java 9d556eb > common/src/main/java/org/apache/sqoop/job/etl/PartitionerContext.java > 79901fd > common/src/main/java/org/apache/sqoop/job/etl/TransferableContext.java > e57bf45 > common/src/main/java/org/apache/sqoop/json/ConfigurableBean.java 49dd057 > common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 6dc14d0 > common/src/main/java/org/apache/sqoop/json/ConnectorsBean.java b04594e > common/src/main/java/org/apache/sqoop/json/DriverBean.java 593ce2f > common/src/main/java/org/apache/sqoop/json/JSONUtils.java e7551d2 > common/src/main/java/org/apache/sqoop/json/JobBean.java 00cba56 > common/src/main/java/org/apache/sqoop/json/JobsBean.java 3c454ea > common/src/main/java/org/apache/sqoop/json/JsonBean.java 7cf24ba > common/src/main/java/org/apache/sqoop/json/LinkBean.java 5ee4e01 > common/src/main/java/org/apache/sqoop/json/LinksBean.java 58cacb9 > common/src/main/java/org/apache/sqoop/json/SchemaBean.java f51fec8 > common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 66db0d4 > common/src/main/java/org/apache/sqoop/json/SubmissionsBean.java 74b6179 > common/src/main/java/org/apache/sqoop/json/ThrowableBean.java cd26020 > common/src/main/java/org/apache/sqoop/json/ValidationResultBean.java > e9b4899 > common/src/main/java/org/apache/sqoop/json/VersionBean.java 53d19b1 > > common/src/main/java/org/apache/sqoop/json/util/ConfigBundleSerialization.java > 6133798 > common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java > df8a870 > > common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java > 4667f5c > common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java > bbd58fc > common/src/main/java/org/apache/sqoop/json/util/SerializationError.java > 3d440da > common/src/main/java/org/apache/sqoop/model/Config.java b4d847d > common/src/main/java/org/apache/sqoop/model/ConfigClass.java f925759 > common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 3765a6d > common/src/main/java/org/apache/sqoop/model/Configurable.java 2033fcb > common/src/main/java/org/apache/sqoop/model/ConfigurationClass.java c65c478 > common/src/main/java/org/apache/sqoop/model/Input.java db3e0e6 > common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 094af39 > common/src/main/java/org/apache/sqoop/model/MBooleanInput.java da380dd > common/src/main/java/org/apache/sqoop/model/MClonable.java 6353779 > common/src/main/java/org/apache/sqoop/model/MConfig.java b5d2afd > common/src/main/java/org/apache/sqoop/model/MConfigList.java 20309e1 > common/src/main/java/org/apache/sqoop/model/MConfigType.java a9f7dad > common/src/main/java/org/apache/sqoop/model/MConfigurableType.java 7ab7032 > common/src/main/java/org/apache/sqoop/model/MConnector.java 1b9462e > common/src/main/java/org/apache/sqoop/model/MDriver.java cc47511 > common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 3faf1d3 > common/src/main/java/org/apache/sqoop/model/MEnumInput.java 28830f4 > common/src/main/java/org/apache/sqoop/model/MFromConfig.java 1e9e845 > common/src/main/java/org/apache/sqoop/model/MInput.java 0074267 > common/src/main/java/org/apache/sqoop/model/MInputType.java af40054 > common/src/main/java/org/apache/sqoop/model/MIntegerInput.java a43f440 > common/src/main/java/org/apache/sqoop/model/MJob.java 935dd18 > common/src/main/java/org/apache/sqoop/model/MLink.java 8e31861 > common/src/main/java/org/apache/sqoop/model/MLinkConfig.java 040dca4 > common/src/main/java/org/apache/sqoop/model/MMapInput.java 37dd265 > common/src/main/java/org/apache/sqoop/model/MNamedElement.java ddacfcd > common/src/main/java/org/apache/sqoop/model/MPersistableEntity.java 6507aca > common/src/main/java/org/apache/sqoop/model/MStringInput.java 289a4ee > common/src/main/java/org/apache/sqoop/model/MSubmission.java ff50c99 > common/src/main/java/org/apache/sqoop/model/MToConfig.java 1d0c91f > common/src/main/java/org/apache/sqoop/model/MValidatedElement.java c0d678a > common/src/main/java/org/apache/sqoop/model/ModelError.java a991781 > common/src/main/java/org/apache/sqoop/model/SubmissionError.java 698877d > common/src/main/java/org/apache/sqoop/model/Validator.java 6368a9d > common/src/main/java/org/apache/sqoop/schema/ByteArraySchema.java 804ebf0 > common/src/main/java/org/apache/sqoop/schema/NullSchema.java 4a9ae11 > common/src/main/java/org/apache/sqoop/schema/Schema.java bc14bcc > common/src/main/java/org/apache/sqoop/schema/SchemaError.java 6b7fb48 > common/src/main/java/org/apache/sqoop/schema/SchemaMatchOption.java e3ab026 > > common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexListType.java > f594f4b > common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java > 7c4200a > common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java > 413eb37 > common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java > 3fccf5a > > common/src/main/java/org/apache/sqoop/schema/type/AbstractPrimitiveType.java > 24acdf1 > common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java > bc1c80b > common/src/main/java/org/apache/sqoop/schema/type/Array.java d34fba8 > common/src/main/java/org/apache/sqoop/schema/type/Binary.java b9622ac > common/src/main/java/org/apache/sqoop/schema/type/Bit.java d5d5b67 > common/src/main/java/org/apache/sqoop/schema/type/Column.java 2d35c3a > common/src/main/java/org/apache/sqoop/schema/type/ColumnType.java d04015e > common/src/main/java/org/apache/sqoop/schema/type/Date.java 2bb72bb > common/src/main/java/org/apache/sqoop/schema/type/DateTime.java 5e237a6 > common/src/main/java/org/apache/sqoop/schema/type/Decimal.java e669700 > common/src/main/java/org/apache/sqoop/schema/type/Enum.java 85a015b > common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java 836e4ad > common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java > 7dcc753 > common/src/main/java/org/apache/sqoop/schema/type/Map.java 244506c > common/src/main/java/org/apache/sqoop/schema/type/Set.java 4e28cad > common/src/main/java/org/apache/sqoop/schema/type/Text.java 9dde1de > common/src/main/java/org/apache/sqoop/schema/type/Time.java e9adce9 > common/src/main/java/org/apache/sqoop/schema/type/Unknown.java 90fb0f0 > common/src/main/java/org/apache/sqoop/submission/SubmissionStatus.java > e2da8f5 > common/src/main/java/org/apache/sqoop/submission/counter/Counter.java > 6b9cfc0 > common/src/main/java/org/apache/sqoop/submission/counter/CounterGroup.java > 62a64c4 > common/src/main/java/org/apache/sqoop/submission/counter/Counters.java > 9298419 > common/src/main/java/org/apache/sqoop/submission/counter/SqoopCounters.java > dd9dd68 > common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 0be4d41 > common/src/main/java/org/apache/sqoop/utils/MapResourceBundle.java 8dbeb70 > common/src/main/java/org/apache/sqoop/utils/UrlSafeUtils.java f448c94 > common/src/main/java/org/apache/sqoop/validation/ConfigValidationError.java > 3453648 > > common/src/main/java/org/apache/sqoop/validation/ConfigValidationResult.java > 4c4d123 > > common/src/main/java/org/apache/sqoop/validation/ConfigValidationRunner.java > 8c66b3d > common/src/main/java/org/apache/sqoop/validation/Message.java 3361b6f > common/src/main/java/org/apache/sqoop/validation/Status.java 1b5ad88 > > common/src/main/java/org/apache/sqoop/validation/validators/AbstractValidator.java > 9dbb44c > > common/src/main/java/org/apache/sqoop/validation/validators/CSVURIValidator.java > a82a238 > > common/src/main/java/org/apache/sqoop/validation/validators/ClassAvailable.java > ed7434f > common/src/main/java/org/apache/sqoop/validation/validators/Contains.java > 98118dc > > common/src/main/java/org/apache/sqoop/validation/validators/DatasetURIValidator.java > 2a69d5c > > common/src/main/java/org/apache/sqoop/validation/validators/HostAndPortValidator.java > 613aee4 > common/src/main/java/org/apache/sqoop/validation/validators/NotEmpty.java > b189299 > common/src/main/java/org/apache/sqoop/validation/validators/NotNull.java > 1235d0e > > common/src/main/java/org/apache/sqoop/validation/validators/NullOrContains.java > f502006 > common/src/main/java/org/apache/sqoop/validation/validators/StartsWith.java > c9a2a0f > connector/connector-sdk/pom.xml ff79ec1 > > connector/connector-sdk/src/main/java/org/apache/sqoop/configurable/ConfigurableError.java > ee11846 > > connector/connector-sdk/src/main/java/org/apache/sqoop/configurable/ConfigurableUpgradeUtil.java > 715a61c > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/AvroDataTypeUtil.java > a71385b > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/EmptyConfiguration.java > 60b9e93 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/FileFormat.java > 0625fce > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/JarUtil.java > acdda6d > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopAvroUtils.java > c19c7f4 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java > 800630f > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java > 4d68ea0 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormatError.java > 3dcbf4a > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > 4870fae > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormatError.java > 9aae251 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java > 6f945c2 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormatError.java > f4e1fb7 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java > c8df6e0 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormatError.java > 72d9d87 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/LocationMatcher.java > d92723e > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/Matcher.java > 36ac5a5 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/MatcherError.java > 577b091 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/MatcherFactory.java > ae89e6c > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java > 7cbc39f > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/spi/ConnectorConfigurableUpgrader.java > b5e0c0d > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java > ff6392e > connector/connector-sdk/src/main/java/org/apache/sqoop/job/Constants.java > 90935cf > > connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Destroyer.java > 8486154 > > connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Extractor.java > 85e91ef > connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/From.java > 3dd8fb9 > > connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Initializer.java > 7dd156e > connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Loader.java > e47b244 > > connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Partition.java > db07844 > > connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Partitioner.java > 3636130 > connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/To.java > 64ba225 > > connector/connector-sdk/src/main/java/org/apache/sqoop/job/etl/Transferable.java > dfe1d5e > pom.xml 3297c00 > > Diff: https://reviews.apache.org/r/29876/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Abraham Elmahrek > >
