----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30134/#review69111 -----------------------------------------------------------
Ship it! Looks fantastic. Simple fix, good tests, good docs. I'll commit when I get my user. Or someone else can commit. Whichever happens first. - Gwen Shapira On Jan. 21, 2015, 8:34 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30134/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 8:34 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1572 > https://issues.apache.org/jira/browse/SQOOP-1572 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit a0245666edcc74fa87ab40d917c2415241a3c3f7 > Author: Abraham Elmahrek <[email protected]> > Date: Wed Jan 21 10:00:57 2015 -0800 > > SQOOP-1572: Sqoop2: Duplicate Column Name in Multiple Tables Import > > :100644 100644 ff42949... 425b2cc... M > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java > :100644 100644 bcc5b43... f67e187... M docs/src/site/sphinx/Connectors.rst > :100644 100644 85b9d2d... aa9f212... M > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java > > > Diffs > ----- > > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java > ff42949 > docs/src/site/sphinx/Connectors.rst bcc5b43 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java > 85b9d2d > > Diff: https://reviews.apache.org/r/30134/diff/ > > > Testing > ------- > > mvn integration-test + test with MySQL: SELECT id as i, id as j FROM fl WHERE > ${CONDITIONS} and SELECT fl.id as i, flv.id as j FROM fl INNER JOIN flv ON > fl.id = flv.id WHERE ${CONDITIONS}. This requires the boundary query to be > provided. > > > Thanks, > > Abraham Elmahrek > >
