> On Jan. 22, 2015, 11:03 p.m., Abraham Elmahrek wrote: > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java, > > lines 168-171 > > <https://reviews.apache.org/r/30184/diff/3/?file=830397#file830397line168> > > > > There's no need to set the rounding mode? There's a method that uses > > some java default? Is there a reason we're not using it? > > Veena Basavaraj wrote: > thats the default I dug up, I did not see any java defualt. can you point > it? > > Abraham Elmahrek wrote: > > http://docs.oracle.com/javase/7/docs/api/java/math/BigDecimal.html#setScale(int)
I did read that, there is no default, hence I used the default that MathContext uses and added that is comment - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30184/#review69361 ----------------------------------------------------------- On Jan. 23, 2015, 11:14 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30184/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2015, 11:14 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2027 > https://issues.apache.org/jira/browse/SQOOP-2027 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java > 4ec2f65 > common/src/main/java/org/apache/sqoop/schema/type/Decimal.java b7572cd > common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java abbfbb4 > > common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java > b7741ec > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java > 425b2cc > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java > bc720da > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/util/SqlTypesUtils.java > d84498e > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java > c2b4b30 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java > 32f6a86 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/common/TestSqoopIDFUtils.java > 63c9535 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java > cbbbd44 > > Diff: https://reviews.apache.org/r/30184/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
