[
https://issues.apache.org/jira/browse/SQOOP-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289912#comment-14289912
]
Sqoop QA bot commented on SQOOP-2027:
-------------------------------------
Testing file
[SQOOP-2027-v1.patch|https://issues.apache.org/jira/secure/attachment/12694226/SQOOP-2027-v1.patch]
against branch sqoop2 took 0:39:22.210685.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed
{color:green}SUCCESS:{color} All integration tests passed
Console output is available
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/987/console].
This message is automatically generated.
> Sqoop2: SqoopIDFUtils handling of decimal need to be fixed
> ----------------------------------------------------------
>
> Key: SQOOP-2027
> URL: https://issues.apache.org/jira/browse/SQOOP-2027
> Project: Sqoop
> Issue Type: Bug
> Reporter: Veena Basavaraj
> Assignee: Veena Basavaraj
> Fix For: 1.99.5
>
> Attachments: SQOOP-2027-v1.patch, SQOOP-2027.patch
>
>
> we need to handle scale and precision and make sure we instantiate the
> bigDecimal correctly
> We also need to make scale and precision mandatory to avoid confusion for
> connectors while they map their types
> {code}
> public class Decimal extends AbstractNumber {
> /**
> * Number of valid numbers.
> */
> private Long precision;
> /**
> * Number of decimal places.
> */
> private Long scale;
> {code}
> IDF java handling today is very lame!
> {code}
> public static Object toDecimal(String csvString, Column column) {
> return new BigDecimal(csvString);
> }
> {code}
> 3. there is no single unit test today with the values for precision and
> scale, so we need to define what those values are for Long
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
