----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30227/#review69711 -----------------------------------------------------------
I'm not sure I like how the code looks after wrapping everything in getColumnName and getTableName... are we sure this is preferable to adding the quotes to the constants? It will be a much more compartmentalized change. repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java <https://reviews.apache.org/r/30227/#comment114432> does it make sense to have a single-argument getColumnName and getTableName? - Gwen Shapira On Jan. 24, 2015, 3:50 a.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30227/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2015, 3:50 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2041 > https://issues.apache.org/jira/browse/SQOOP-2041 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit d3c8d226315b42b122cbed027434132a5ccfce63 > Author: Abraham Elmahrek <[email protected]> > Date: Fri Jan 23 09:10:53 2015 -0800 > > SQOOP-2041: Sqoop2: Escape table names when creating repository tables > > :000000 100644 0000000... 757c6d1... A > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java > :100644 100644 1e13932... 5c9247a... M > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java > :100644 100644 69c55df... e0b187c... M > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java > :000000 100644 0000000... c6c0573... A > repository/repository-common/src/test/java/org/apache/sqoop/repository/common/TestCommonRepoUtils.java > :000000 100644 0000000... 44ffced... A > repository/repository-common/src/test/resources/log4j.properties > :100644 100644 6d35143... 3bef3c5... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > :100644 100644 4a7afcf... 0683853... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java > :100644 100644 af76a17... e98b598... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java > :100644 100644 d5cabd0... 5b1cce2... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java > :100644 100644 39abb2d... 7b47605... M > repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java > :100644 100644 a6319ac... 766977c... M > repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java > > > Diffs > ----- > > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java > PRE-CREATION > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java > 1e13932 > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java > 69c55df > > repository/repository-common/src/test/java/org/apache/sqoop/repository/common/TestCommonRepoUtils.java > PRE-CREATION > repository/repository-common/src/test/resources/log4j.properties > PRE-CREATION > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 6d35143 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java > 4a7afcf > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java > af76a17 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java > d5cabd0 > > repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java > 39abb2d > > repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java > a6319ac > > repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java > ae546f3 > > repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java > f393521 > > repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java > 6075de4 > > Diff: https://reviews.apache.org/r/30227/diff/ > > > Testing > ------- > > mvn integration-test > > > Thanks, > > Abraham Elmahrek > >
