----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30374/#review70145 -----------------------------------------------------------
src/java/org/apache/sqoop/mapreduce/ExportJobBase.java <https://reviews.apache.org/r/30374/#comment115146> Nit. Should we set the default to 1 and if the value of SQOOP_EXPORT_MAP_TASK_MAX_ATTEMPTS is > 1 then set the hadoop config property? Good idea Jarcec. Just one small nit. - Venkat Ranganathan On Jan. 28, 2015, 5:04 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30374/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2015, 5:04 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2055 > https://issues.apache.org/jira/browse/SQOOP-2055 > > > Repository: sqoop-trunk > > > Description > ------- > > I've implemented the suggestion as described on the JIRA. > > > Diffs > ----- > > src/java/org/apache/sqoop/mapreduce/ExportJobBase.java cb846e8 > > Diff: https://reviews.apache.org/r/30374/diff/ > > > Testing > ------- > > All tests are passing and I've verified the error condition by manually > killing query on database side. > > > Thanks, > > Jarek Cecho > >
