----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30304/#review70327 -----------------------------------------------------------
Ship it! Ship It! - Abraham Elmahrek On Jan. 27, 2015, 3:40 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30304/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 3:40 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Move all ErrorCode child class into Sqoop common component. > > > Diffs > ----- > > > common/src/main/java/org/apache/sqoop/error/code/AVROIntermediateDataFormatError.java > PRE-CREATION > > common/src/main/java/org/apache/sqoop/error/code/CSVIntermediateDataFormatError.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/error/code/ConfigurableError.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/error/code/DerbyRepoError.java > PRE-CREATION > > common/src/main/java/org/apache/sqoop/error/code/GenericJdbcConnectorError.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/error/code/HdfsConnectorError.java > PRE-CREATION > > common/src/main/java/org/apache/sqoop/error/code/IntermediateDataFormatError.java > PRE-CREATION > > common/src/main/java/org/apache/sqoop/error/code/JSONIntermediateDataFormatError.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/error/code/KafkaConnectorErrors.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/error/code/KiteConnectorError.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/error/code/MRExecutionError.java > PRE-CREATION > > common/src/main/java/org/apache/sqoop/error/code/MapreduceSubmissionError.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/error/code/MatcherError.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/error/code/PostgresqlRepoError.java > PRE-CREATION > common/src/main/java/org/apache/sqoop/error/code/ServerError.java > PRE-CREATION > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorError.java > 0fa4a32193024ac996978a72305884776432b234 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java > e94a19be6f5110d61c8e585204544435b5361207 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java > a34995642cc3669a7776a15c52195dbdeb2538ed > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java > 1b30fb4ae21de1d3bfbe5ace471a91e67caa60f4 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java > b68d8d0b35a3a57d5ee07d82c6f6e58dc80c1f1b > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java > 5e6f983a982b4a6cf00d91769acf21eeaa1012e9 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java > f70142d287fa7983434280faf687a02f348dfcc1 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorError.java > 71f0a0323a034d30236a1ae33aed8fe4a511743e > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java > 9f3367b4d942ed82475c66ba62c1e039bf2d76f8 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java > 556c11274131e150f7f64b812e466ded6c783772 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsPartitioner.java > 181528cc5fe6e802398b396edacc75884f108c99 > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaConnectorErrors.java > f94efea6ee17268fda8d8824645c3445b2860d2b > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaLoader.java > 1c08f6026d17f5203fb9eda10d9d8bf0f1116317 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnectorError.java > 5775fcf6a5c8cd569f500c8951391386e13bd36a > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java > e4514b57d8b7755184c73b2c1394302a5e3d4b5f > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteFromInitializer.java > 2f82eaa725ac36141b6627b92e848f6736bc9f92 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java > ef94d48b548ff6ea58f7415f7c84ffe2d8ee62fe > > connector/connector-sdk/src/main/java/org/apache/sqoop/configurable/ConfigurableError.java > 6236870bc63b7298a5264d341693506ff58e3631 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopAvroUtils.java > 5e6f238d99b0e7215bdee98f73bde8f30bd5504f > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java > c5eb6a38f1c4df624e3fc93110da2c7abf7945de > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java > 335059992c8a02e33f07adf54306fa7a0d7882f7 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormatError.java > fd1b7d35c66d043ba6bfc4e331a07d0517f1a588 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java > b716e79379fef67561dbfb745e82dae9731f9e28 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormatError.java > 6828bb90f0b79c9be02e4e9290d274b9ea845286 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java > 8bcf8c30af460d97c8e09ee7fd82972f7369a5cd > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormatError.java > f7c9abb453bb84f7a8ec86df057faa3f18aad124 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java > 4c67c1ab52dae4457bd4f0ef690bf2addd3edd41 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormatError.java > 0c29a8fe46d7bdf54c3bd059ec7b84b6b7909044 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/MatcherError.java > 18693c27e8323064ae76bb6ae5705f730e7ce061 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/spi/ConnectorConfigurableUpgrader.java > 55f8edbea38dd15ba7a72446244fce695a9dac81 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java > e70b7e238bf6e838cd4f2536056164bef9743210 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java > a562e020f7052f0ec5588911d249134a52adf1ee > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java > dee00118a33c1c5f82f21c2e9376d5c1b16cbe81 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java > 58a9eed66c502310584750159fe8cbacee48987d > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java > c2f57563148a015dd876d0a33867107dc18032bf > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryError.java > 7a7b28c646ff1a319b55693cab70e1ba4ec87131 > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java > 1e139327e72bdb6b68c1b78b6a20b34f0af2c103 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java > 6bc567406aff0124dd3048b11283fd1b067a2ee5 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 6d3514349fd300e3bc54bccf0c55540a5abeb8d8 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java > 458450bd3df1a1374a3c1e5a9241f47a1450c13e > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java > 5602c7c7d4060e58a0404e8b65565bbc8bd1a03b > > repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoError.java > 19ee505cc2bbacccad42cf98c3bacb70831e7e41 > > repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java > 4013d22c1b0c33165d9dabed1f579b1b533e3c1b > server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java > ccf928eb0efbb2137b9269db03ee444f51c034e6 > server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java > 81efb896b4fe33b30bbc2e33abd1fce9d096440b > server/src/main/java/org/apache/sqoop/handler/HandlerUtils.java > 93ff60b000b6f566b80786463577a378b232a142 > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > f4482cee7459febb37bb747a011f611655412783 > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java > 74fa321a57468e9b75b75213f0ee20ed708c8ead > server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java > a0b29c86b7b7d7fe8d5fc185164c7899050083ca > server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java > 2eaa0ac2be66a196c72542594cf5436ae7266e82 > server/src/main/java/org/apache/sqoop/server/RequestContext.java > 5324a0a06386e34e33a56f45fea2233b27789de5 > server/src/main/java/org/apache/sqoop/server/common/ServerError.java > c68ab57da9e8b0f8adabaff74bd24c4dcecf9c46 > > submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java > d15bcfcab9260888d09a5d55a6b1a7e7465387ac > > submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionError.java > 4af95b072c3e30022e93111d67494e0e08f6fc6d > > Diff: https://reviews.apache.org/r/30304/diff/ > > > Testing > ------- > > > Thanks, > > richard zhou > >
