> On Feb. 2, 2015, 9:54 p.m., Jarek Cecho wrote: > > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java, > > line 145 > > <https://reviews.apache.org/r/29749/diff/8/?file=842750#file842750line145> > > > > Shouldn't we use the newly introduced method "escapeSchemaName()" here? > > Abraham Elmahrek wrote: > Not sure actually. If we escape as a schema name and it doesn't have the > same escape semantics, will it still work in DML statements?
It's the same object type (=schema), so I would assume that it have to be escaped the same way regardless where it's used. For all the databases that I know the schema name is escaped the same way as table name, so I don't have an idea where to verify this theory. > On Feb. 2, 2015, 9:54 p.m., Jarek Cecho wrote: > > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java, > > line 31 > > <https://reviews.apache.org/r/29749/diff/8/?file=842762#file842762line31> > > > > Don't we have generic ProviderAsserts? Those method seems to be generic > > enough to be reused on other databases as well, right? > > Abraham Elmahrek wrote: > Hmm not sure. The metadata definition for JDBC is a bit foreign to me. > Would you mind if we kept it here for now and moved it out? Sure, works for me. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29749/#review70624 ----------------------------------------------------------- On Jan. 31, 2015, 12:11 a.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29749/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2015, 12:11 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1591 > https://issues.apache.org/jira/browse/SQOOP-1591 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit 560387f1d3e6869ada914fa6ae5ada7d8e210721 > Author: Abraham Elmahrek <[email protected]> > Date: Wed Jan 7 20:44:44 2015 -0800 > > SQOOP-1591: Sqoop2: PostgreSQL integration tests > > :100644 100644 8196fe2... cb987f6... M > common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java > :100644 100644 82289e8... 3a6205e... M > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java > :100644 100644 5d80dce... 7248d7c... M > repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java > :000000 100644 0000000... 85f895d... A > repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestConnectorHandling.java > :000000 100644 0000000... 6022bb3... A > repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestDriverHandling.java > :000000 100644 0000000... 1dfacb5... A > repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestJobHandling.java > :000000 100644 0000000... 54c598e... A > repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestLinkHandling.java > :100644 100644 2da19bc... 4735240... M > repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java > :000000 100644 0000000... 9db7940... A > repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestSubmissionHandling.java > > > Diffs > ----- > > > common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java > fb4e7af > > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java > 82289e8 > > common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java > 98591a3 > > common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java > 9814ac8 > > common-test/src/main/java/org/apache/sqoop/common/test/db/NetezzaProvider.java > d31bf28 > > common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java > ed29a23 > > common-test/src/main/java/org/apache/sqoop/common/test/db/PostgreSQLProvider.java > d46e01d > > common-test/src/main/java/org/apache/sqoop/common/test/db/SqlServerProvider.java > 9c56886 > > common-test/src/main/java/org/apache/sqoop/common/test/db/TeradataProvider.java > f99d1ed > repository/repository-postgresql/pom.xml 0ee9081 > > repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepoConstants.java > bdefd4c > > repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java > 85af9a4 > > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java > PRE-CREATION > > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestUtils.java > PRE-CREATION > > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestConnectorHandling.java > PRE-CREATION > > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestDriverHandling.java > PRE-CREATION > > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java > PRE-CREATION > > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java > PRE-CREATION > > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestStructure.java > PRE-CREATION > > repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestSubmissionHandling.java > PRE-CREATION > > repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestCase.java > 98ba7a3 > > repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/PostgresqlTestUtils.java > 19fd6e7 > > repository/repository-postgresql/src/test/java/org/apache/sqoop/repository/postgresql/TestStructure.java > 941bb69 > test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java > 1124cd3 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java > f82abc7 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java > b648870 > > Diff: https://reviews.apache.org/r/29749/diff/ > > > Testing > ------- > > mvn clean test -pl repository/repository-postgresql > -Dsqoop.provider.class=org.apache.sqoop.common.test.db.PostgreSQLProvider > -Dsqoop.provider.postgresql.jdbc=jdbc:postgresql://.../test > -Dsqoop.provider.postgresql.username=test > -Dsqoop.provider.postgresql.password=test > > > Thanks, > > Abraham Elmahrek > >
