[ 
https://issues.apache.org/jira/browse/SQOOP-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305006#comment-14305006
 ] 

Veena Basavaraj commented on SQOOP-1804:
----------------------------------------

even the partitioner test passed

{code}
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.sqoop.integration.connector.jdbc.generic.PartitionerTest
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.595 sec

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ test ---
[INFO] Building jar: 
/Users/vbasavaraj/Projects/SqoopRefactoring/sqoop2/test/target/test-2.0.0-SNAPSHOT-hadoop200.jar
[INFO] 
[INFO] --- maven-surefire-plugin:2.14:test (integration-test) @ test ---
[INFO] Surefire report directory: 
/Users/vbasavaraj/Projects/SqoopRefactoring/sqoop2/test/target/surefire-reports

-------------------------------------------------------
 T E S T S
-------------------------------------------------------

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.sqoop.integration.connector.jdbc.generic.PartitionerTest
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.577 sec

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Sqoop .............................................. SUCCESS [  0.599 s]
[INFO] Sqoop Common Test Libraries ........................ SUCCESS [  1.448 s]
[INFO] Sqoop Common ....................................... SUCCESS [  5.534 s]
[INFO] Sqoop Connectors ................................... SUCCESS [  0.017 s]
[INFO] Sqoop Connector SDK ................................ SUCCESS [  1.829 s]
[INFO] Sqoop Core ......................................... SUCCESS [  2.163 s]
[INFO] Sqoop Repository ................................... SUCCESS [  0.011 s]
[INFO] Sqoop Common Reposi


Changes to be committed:
  (use "git reset HEAD <file>..." to unstage)

        modified:   
common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java
        modified:   
common/src/main/java/org/apache/sqoop/json/util/ConfigInputConstants.java
        modified:   
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java
        modified:   common/src/main/java/org/apache/sqoop/model/ConfigUtils.java
        modified:   common/src/main/java/org/apache/sqoop/model/Input.java
        new file:   
common/src/main/java/org/apache/sqoop/model/InputEditable.java
        modified:   
common/src/main/java/org/apache/sqoop/model/MBooleanInput.java
        modified:   common/src/main/java/org/apache/sqoop/model/MConfig.java
        modified:   common/src/main/java/org/apache/sqoop/model/MEnumInput.java
        modified:   common/src/main/java/org/apache/sqoop/model/MInput.java
        modified:   
common/src/main/java/org/apache/sqoop/model/MIntegerInput.java
        modified:   common/src/main/java/org/apache/sqoop/model/MMapInput.java
        modified:   
common/src/main/java/org/apache/sqoop/model/MStringInput.java
        modified:   
common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java
        modified:   
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java
        modified:   
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java
        modified:   
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
        modified:   
common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java
        modified:   common/src/test/java/org/apache/sqoop/model/TestMConfig.java
        modified:   
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java
        modified:   
common/src/test/java/org/apache/sqoop/model/TestMConnector.java
        modified:   
common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java
        modified:   
common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java
        modified:   common/src/test/java/org/apache/sqoop/model/TestMJob.java
        modified:   common/src/test/java/org/apache/sqoop/model/TestMLink.java
        modified:   
common/src/test/java/org/apache/sqoop/model/TestMMapInput.java
        modified:   
common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java
        modified:   
common/src/test/java/org/apache/sqoop/model/TestMStringInput.java
        modified:   
common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java
        modified:   
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java
        modified:   
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java
        modified:   
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
        modified:   
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java
        modified:   
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java
        modified:   
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
        modified:   
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
        modified:   
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java
        modified:   
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java
        modified:   
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
        modified:   
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java
        modified:   
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java
        modified:   
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java
        modified:   
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
        modified:   
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java
        modified:   
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java
        modified:   shell/src/main/resources/shell-resource.properties



{code}

> Repository Structure + API: Storing/Retrieving the From/To config inputs ( 
> editable/ overrides)
> -----------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-1804
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1804
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Veena Basavaraj
>            Assignee: Veena Basavaraj
>             Fix For: 1.99.5
>
>         Attachments: SQOOP-1804-v1.patch, SQOOP-1804-v4.patch, 
> SQOOP-1804-v5-1.patch, SQOOP-1804-v5.patch, SQOOP-1804.patch
>
>
> Details of this proposal are in the wiki.
> https://cwiki.apache.org/confluence/display/SQOOP/Delta+Fetch+And+Merge+Design#DeltaFetchAndMergeDesign-Wheretostoretheoutputinsqoop?
> Update: The above highlights the pros and cons of each approach. 
> #4 is chosen, since it is less intrusive, more clean and allows U/Edit per 
> value in the output easily.
> Will use this ticket for more detailed discussion on storage options for the 
> output from connectors
> 1. 
> {code}
> // will have FK to submission
>  public static final String QUERY_CREATE_TABLE_SQ_JOB_OUTPUT_SUBMISSION =
>      "CREATE TABLE " + TABLE_SQ_JOB_OUTPUT + " ("
>      + COLUMN_SQ_JOB_OUT_ID + " BIGINT GENERATED ALWAYS AS IDENTITY (START 
> WITH 1, INCREMENT BY 1), "
>      + COLUMN_SQ_JOB_OUT_KEY + " VARCHAR(32), "
>      + COLUMN_SQ_JOB_OUT_VALUE + " LONG VARCHAR,"
>      + COLUMN_SQ_JOB_OUT_TYPE + " VARCHAR(32),"
>      + COLUMN_SQD_ID + " VARCHAR(32)," // FK to the direction table, since 
> this allows to distinguish output from FROM/ TO part of the job
>    + COLUMN_SQRS_SUBMISSION + " BIGINT, "
>    + "CONSTRAINT " + CONSTRAINT_SQRS_SQS + " "
>      + "FOREIGN KEY (" + COLUMN_SQRS_SUBMISSION + ") "
>        + "REFERENCES " + TABLE_SQ_SUBMISSION + "(" + COLUMN_SQS_ID + ") ON 
> DELETE CASCADE "
> {code}
> 2.
> At the code level, we will define  MOutputType, one of the types can be BLOB 
> as well, if a connector decides to store the value as a BLOB
> {code}
> class JobOutput {
> String key;
> Object value;
> MOutputType type;
> }
> {code}
> 3. 
> At the repository API, add a new API to get job output for a particular 
> submission Id and allow updates on values. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to