----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30705/#review71360 -----------------------------------------------------------
core/src/main/java/org/apache/sqoop/security/AuthorizationAccessController.java <https://reviews.apache.org/r/30705/#comment117056> I recommend the dropRole is better. core/src/main/java/org/apache/sqoop/security/AuthorizationAccessController.java <https://reviews.apache.org/r/30705/#comment117057> May be can change showPrivileges(MPrincipal principal, MPrivilege privilege) //Show privileges for given principal on given object core/src/main/java/org/apache/sqoop/security/AuthorizationAccessController.java <https://reviews.apache.org/r/30705/#comment117058> lack of a function getAllRoles(). This function is very useful when a admin user want to see how many roles exist in the sqoop - shen guoquan On 二月 6, 2015, 1:46 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30705/ > ----------------------------------------------------------- > > (Updated 二月 6, 2015, 1:46 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Remove useless functions, according to > https://cwiki.apache.org/confluence/display/Hive/Hive+Default+Authorization+-+Legacy+Mode > > > Diffs > ----- > > > core/src/main/java/org/apache/sqoop/security/AuthorizationAccessController.java > 54fa556edc60622ac6d2e3bc9f7c010894451c22 > core/src/main/java/org/apache/sqoop/security/AuthorizationHandler.java > 5f3231be169ae0d42734628571b06da491ae5c64 > core/src/main/java/org/apache/sqoop/security/AuthorizationValidator.java > c6482fbe3e63c8c82da49e43a515b8998b6ab264 > > security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationAccessController.java > 02f8f3b129cd8f63cda937f5a7de1b3192624cf0 > > security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationHandler.java > 8e63b86f03ff67af5bc59d61325d749f81fd2745 > > security/src/main/java/org/apache/sqoop/security/Authorization/DefaultAuthorizationValidator.java > bbde2816cd62235ee30fca99e10eaf65f34890b6 > > Diff: https://reviews.apache.org/r/30705/diff/ > > > Testing > ------- > > > Thanks, > > richard zhou > >
